Closed angrezichatterbox closed 3 months ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Android repo[ ] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
I'm getting some errors in trying to build this, @angrezichatterbox :)
e: .../Scribe-Android/app/src/main/kotlin/org/scribe/services/SimpleKeyboardIME.kt: (45, 5): 'hasTextBeforeCursor' overrides nothing
e: .../Scribe-Android/app/src/main/kotlin/org/scribe/services/SimpleKeyboardIME.kt: (56, 5): 'commitPeriodAfterSpace' overrides nothing
Do you want to take a look at them? I'll get the PR template up now :)
PR template is here, and you'll see the raw text in your next PR, @angrezichatterbox. Let me know if you have any suggestions for the template!
I'm getting some errors in trying to build this, @angrezichatterbox :)
e: .../Scribe-Android/app/src/main/kotlin/org/scribe/services/SimpleKeyboardIME.kt: (45, 5): 'hasTextBeforeCursor' overrides nothing e: .../Scribe-Android/app/src/main/kotlin/org/scribe/services/SimpleKeyboardIME.kt: (56, 5): 'commitPeriodAfterSpace' overrides nothing
Do you want to take a look at them? I'll get the PR template up now :)
I have fixed the error . I forgot to implement the functions after creating a branch from the new main.
PR template is here, and you'll see the raw text in your next PR, @angrezichatterbox. Let me know if you have any suggestions for the template!
Thanks , It is very helpful
I'll get to the review later this evening, @angrezichatterbox :)
What would be an issue you'd think to look into next? Maybe #27 so we can finish that functionality up? There was a PR, but it only works for some devices.
What would be an issue you'd think to look into next? Maybe #27 so we can finish that functionality up? There was a PR, but it only works for some devices.
I will check it out and start working on that issue
The pull request is to make the keyboard similar to the iOS Scribe-App by adding white key and a small shadow below the keys