scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
39 stars 38 forks source link

feat:Added Shadow to the keys and reduced border radius #37

Closed angrezichatterbox closed 3 months ago

angrezichatterbox commented 4 months ago

The pull request is to make the keyboard similar to the iOS Scribe-App by adding white key and a small shadow below the keys

github-actions[bot] commented 4 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 3 months ago

I'm getting some errors in trying to build this, @angrezichatterbox :)

e: .../Scribe-Android/app/src/main/kotlin/org/scribe/services/SimpleKeyboardIME.kt: (45, 5): 'hasTextBeforeCursor' overrides nothing
e: .../Scribe-Android/app/src/main/kotlin/org/scribe/services/SimpleKeyboardIME.kt: (56, 5): 'commitPeriodAfterSpace' overrides nothing

Do you want to take a look at them? I'll get the PR template up now :)

andrewtavis commented 3 months ago

PR template is here, and you'll see the raw text in your next PR, @angrezichatterbox. Let me know if you have any suggestions for the template!

angrezichatterbox commented 3 months ago

I'm getting some errors in trying to build this, @angrezichatterbox :)

e: .../Scribe-Android/app/src/main/kotlin/org/scribe/services/SimpleKeyboardIME.kt: (45, 5): 'hasTextBeforeCursor' overrides nothing
e: .../Scribe-Android/app/src/main/kotlin/org/scribe/services/SimpleKeyboardIME.kt: (56, 5): 'commitPeriodAfterSpace' overrides nothing

Do you want to take a look at them? I'll get the PR template up now :)

I have fixed the error . I forgot to implement the functions after creating a branch from the new main.

angrezichatterbox commented 3 months ago

PR template is here, and you'll see the raw text in your next PR, @angrezichatterbox. Let me know if you have any suggestions for the template!

Thanks , It is very helpful

andrewtavis commented 3 months ago

I'll get to the review later this evening, @angrezichatterbox :)

andrewtavis commented 3 months ago

What would be an issue you'd think to look into next? Maybe #27 so we can finish that functionality up? There was a PR, but it only works for some devices.

angrezichatterbox commented 3 months ago

What would be an issue you'd think to look into next? Maybe #27 so we can finish that functionality up? There was a PR, but it only works for some devices.

I will check it out and start working on that issue