Update App UI to a tab bar

scribe-org / Scribe-Android

Android app with keyboards for language learners

GNU General Public License v3.0

27 stars 14 forks source link

Update App UI to a tab bar #40

Closed andrewtavis closed 1 month ago

andrewtavis commented 2 months ago

Terms

[X] I have searched open and closed feature requests
[X] I agree to follow Scribe-Android's Code of Conduct

Description

This issue would convert over the Scribe-Android app UI to use a tab bar at the bottom of the screen. The basis of this can be seen in the designs on Figma where the application has Installation, Settings, and About tabs.

What this issue would entail is:

An installation tab with the current home app screen
A settings tab with any keyboard related settings
- This does not need to be based on keyboards now!
- Let's start with settings for all keyboards and switch to per keyboard settings at a later time
An about tab with any contact information from the application

From here we will make more issues on expanding out the various pages of the application! 🚀

Contribution

Happy to support as I can and review. Making this issue for @angrezichatterbox via discussions in #39 😊

angrezichatterbox commented 2 months ago

I would start working on this issue. :)

andrewtavis commented 2 months ago

Thank you, @angrezichatterbox! Really excited to see this progress :) :)

angrezichatterbox commented 2 months ago

This is how the navbar looks for the dark and light modes respectively, Is there any change that you would like before I make a PR I am sorry it took longer than usual. I had some personal work to do.

andrewtavis commented 1 month ago

No stress, @angrezichatterbox! Is looking good to me 😊 We should make further issues for coloration and such, but that can be later :) Quick check on this that I'm realizing I forgot to mention: Is the tab bar able to be swiped? If so, then I think we're good to go! Would be nice to have that, but if not we could also do another issue for that :)

angrezichatterbox commented 1 month ago

I have added the swipeGesture for changing the tabs. I will make a PR.

angrezichatterbox commented 1 month ago

I have made the PR, is there any other issue you would like me to work on?

andrewtavis commented 1 month ago

Thanks for this, @angrezichatterbox! Give me a moment to bring the current two PRs in and then we can make some more :) Will try to review this weekend or early next week, and maybe we can do a call after?

andrewtavis commented 1 month ago

Closed by #41 🚀 Thank you for your dedication, @angrezichatterbox! Really amazing how quickly you've been able to figure out all of this 😊