Set up keyboard based settings pages

scribe-org / Scribe-Android

Android app with keyboards for language learners

GNU General Public License v3.0

27 stars 14 forks source link

Set up keyboard based settings pages #46

Closed andrewtavis closed 2 weeks ago

andrewtavis commented 1 month ago

Terms

[X] I have searched open and closed feature requests
[X] I agree to follow Scribe-Android's Code of Conduct

Description

Scribe-iOS provides settings for each individual keyboard. As seen on the designs on Figma as well as in the image below, each keyboard that is activated has a settings page beneath the global settings tab.

Keyboard Settings - Light

This issue would do the following:

Each installed keyboard would have an option to go to its settings on the Settings tab
The settings page for each keyboard would just have a back button for now
If there are no keyboards installed, then an Install keyboards button would be present as seen in the designs here
- This is assuming that the user will not be forced to install a keyboard upon opening the app
- We won't need to do this if we do insist that the user has already installed a keyboard to navigate through the application

Contribution

Happy to support this any way that I can and review when we're ready to look into the solution! 😊

andrewtavis commented 3 weeks ago

Assigning this to you per our discussions, @angrezichatterbox :)

angrezichatterbox commented 3 weeks ago

Should I implement the Double space period in the individual keyboard settings?

Also, Could I make the settings page similar to Scribe-iOS? This would include making the App Language go to the App Language Settings and the current checkboxes turned into a switch similar to Scribe-iOS and Figma. Should it be kept for a separate issue?

andrewtavis commented 3 weeks ago

Hey @angrezichatterbox 👋

Should I implement the Double space period in the individual keyboard settings?

Yes, we decided that all keyboard based settings would be in individual keyboards for consistency as some do need to be there :)

Also, Could I make the settings page similar to Scribe-iOS? This would include making the App Language go to the App Language Settings and the current checkboxes turned into a switch similar to Scribe-iOS and Figma. Should it be kept for a separate issue?

I think it makes sense to include it in here, yes :) All sounds great 😊 Thank you!

angrezichatterbox commented 3 weeks ago

Yes, we decided that all keyboard based settings would be in individual keyboards for consistency as some do need to be there :)

I meant the description of the current issues states that there should be only a back button on the page for each keyboard setting. Should I implement just the double space period in the individual keyboard setting for now?

andrewtavis commented 3 weeks ago

Ahhhh yes yes :) I forgot for a moment that that option's already done as we don't even have it in Scribe-iOS 😇 Sounds great, thank you!

angrezichatterbox commented 3 weeks ago

I have implemented the pages and the functionality of the individual keyboard settings as the selected keyboards from the settings.

Without Keyboard Selected	With Keyboard Selected

Are there any changes to be made or any of those switches I have implemented be moved to individual keyboard settings?

The Language settings are like below.

My pr would take a little more time as for some reason I am not able to move to app language settings even though I am using a device with API 34.

andrewtavis commented 3 weeks ago

This is absolutely beautiful, @angrezichatterbox! I think that any design changes can happen later :) Let's get this done with the work that you have left and then do another PR. Really great! 😊

angrezichatterbox commented 3 weeks ago

I have created a pull request for this issue. :)

andrewtavis commented 2 weeks ago

Closed via #63 🚀 Thanks for getting to this so quickly, @angrezichatterbox! Lots of new things that can be worked on now 😊 Will write to ask about next steps!