Change Application identifier

[angrezichatterbox]

Description

The pull request changes the application identifier from org.scribe to be.scri.

Related issue

• 42

• Additional information

  1. For some reason the old method of checking of whether it was a new user and telling the user to go to settings didn't seem to work so I had to make the check using the package name of those input picker additions. Should I revert that change. ?

[github-actions[bot]]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• [x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo

• [x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[andrewtavis]

Hey @angrezichatterbox 👋

For some reason the old method of checking of whether it was a new user and telling the user to go to settings didn't seem to work so I had to make the check using the package name of those input picker additions. Should I revert that change. ?

We actually discussed in the sync today, and we would prefer for the app to not force the user to install a keyboard. We'll direct them to install the keyboard on the installation page, and keyboard settings will be conditional on them being installed. It should be ok to revert that change so that the app opens without the tooltip telling the user to install the keyboard. Can you remove the code for that?

[angrezichatterbox]

Hey @angrezichatterbox 👋

For some reason the old method of checking of whether it was a new user and telling the user to go to settings didn't seem to work so I had to make the check using the package name of those input picker additions. Should I revert that change. ?

We actually discussed in the sync today, and we would prefer for the app to not force the user to install a keyboard. We'll direct them to install the keyboard on the installation page, and keyboard settings will be conditional on them being installed. It should be ok to revert that change so that the app opens without the tooltip telling the user to install the keyboard. Can you remove the code for that?

I have reverted the change.

[andrewtavis]

Checking it right now :) On build I'm getting the following error:

Activity class {org.scribe.debug/be.scri.activities.SplashActivity.Orange} does not exist

Maybe there's a spot where it's still org.scribe in the code?

[angrezichatterbox]

Checking it right now :) On build I'm getting the following error:

Activity class {org.scribe.debug/be.scri.activities.SplashActivity.Orange} does not exist

Maybe there's a spot where it's still org.scribe in the code?

I have replaced it now in the latest commit to wherever I found org.scribe. I'm sorry that I didn't check again. the refractor of Android Studio does not change it everywhere. Could you try to invalidate the cache and rebuild it as I am not able to replicate the same error.

[andrewtavis]

Sure, will do a little later today, @angrezichatterbox!