Improve light and dark mode coloration and add background color to all tabs

scribe-org / Scribe-Android

Android app with keyboards for language learners

GNU General Public License v3.0

27 stars 14 forks source link

Improve light and dark mode coloration and add background color to all tabs #51

Closed andrewtavis closed 1 month ago

andrewtavis commented 1 month ago

Terms

[X] I have searched open and closed design issues
[X] I agree to follow Scribe-Android's Code of Conduct

Description

This issue would finalize the conversion from light to dark mode for the Scribe-Android application. In addition, it would also be nice if Scribe Blue was made the background for the remaining tabs of the application - i.e. Installation and Settings.

Note: This issue is blocked by #43 where the color variables will be added in a way that is sustainable for future development

Contribution

@angrezichatterbox has expressed interest in handling this one 😊 Happy to review when it's all ready!

andrewtavis commented 1 month ago

Ah nice, @angrezichatterbox :) As you're on Triage rights I can assign you directly now. You should also be able to assign yourself for #43? Do you want to do one PR for that one and this one?

angrezichatterbox commented 1 month ago

I would make a single PR for both issues. Whichever sounds better to you. I am also okay with making separate PR if that would be better for review.

andrewtavis commented 1 month ago

No no, let's do a single one for both, @angrezichatterbox :) Thanks for the communication here during planning!

angrezichatterbox commented 1 month ago

I have made a single pull request for both issues. Please tell me if there are any changes to be made. I have tried to add all the colours from the Figma Reference. and Tried to make the dark and light mode similar to Scribe-iOS

andrewtavis commented 1 month ago

Thanks for this, @angrezichatterbox! Will try to review soon :)

andrewtavis commented 1 month ago

Closed via #53 :) Thanks so much for this, @angrezichatterbox!