search

scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
27 stars 14 forks source link

Add Wikimedia and Scribe page to About tab #52

Closed andrewtavis closed 1 month ago

andrewtavis commented 1 month ago

Terms

Description

This issue would add the Wikimedia and Scribe page to the About tab of the Scribe-Android application :) The designs for it can be found here, with an image of the page being found below:

Wikimedia and Scribe - Light

We'll need to include the logos for Wikidata and Wikipedia, as well as make sure that the back button for sub-pages is functioning correctly.

Contribution

@angrezichatterbox expressed interest in working on this one 😊 Happy to review and support as I can!

angrezichatterbox commented 1 month ago

So currently there is an action bar at the top for the Scribe-Android. Would it be removed at some point to make the app similar to Scribe-iOS?If so should I consider that and make the Wikimedia and Scribe Text not on the action bar or should I put it on the action bar for now?

andrewtavis commented 1 month ago

Maybe it's ok to leave it, @angrezichatterbox? We have a top header for Scribe-iOS as well that will function similar to an action bar. That also has a light shadow under it on scroll, so I think if we just blend the action bar in it's basically the same?

angrezichatterbox commented 1 month ago

I have created a pull request for this. I haven't customized the action bar for the page since it would be better if that were done universally for all pages together. Please do give suggestions for any changes to be made to the page. :)

andrewtavis commented 1 month ago

Closed via #54 🎉 So much progress, @angrezichatterbox! Really is starting to take shape, and it was super great to be able to tell the Wikidata Lexeme community that there's been so much progress here! Thanks so much :)