Closed angrezichatterbox closed 1 month ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Android repo[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Hey @angrezichatterbox 👋 I've set up a new device at this point and it's telling me that the Gradle settings are out of date, so I can't build the app. Would we be able to upgrade the Gradle settings as a part of this, and then hopefully I'll be able to review?
Hey @angrezichatterbox 👋 I've set up a new device at this point and it's telling me that the Gradle settings are out of date, so I can't build the app. Would we be able to upgrade the Gradle settings as a part of this, and then hopefully I'll be able to review?
Ya, I will upgrade the Gradle and push the changes.
I have updated the Gradle version. I have to upgrade some dependencies along with it. Due to this, I had to make layout changes to the About activity and the Wikimedia Scribe page I had just created.
Thanks for all the effort here, @angrezichatterbox! 🏆
Will get to the review soon :)
Contributor checklist
Description
Related issue
52