scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
27 stars 14 forks source link

Implements Wikimedia and Scribe Page #54

Closed angrezichatterbox closed 1 month ago

angrezichatterbox commented 1 month ago

Contributor checklist


Description

github-actions[bot] commented 1 month ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 1 month ago

Hey @angrezichatterbox 👋 I've set up a new device at this point and it's telling me that the Gradle settings are out of date, so I can't build the app. Would we be able to upgrade the Gradle settings as a part of this, and then hopefully I'll be able to review?

angrezichatterbox commented 1 month ago

Hey @angrezichatterbox 👋 I've set up a new device at this point and it's telling me that the Gradle settings are out of date, so I can't build the app. Would we be able to upgrade the Gradle settings as a part of this, and then hopefully I'll be able to review?

Ya, I will upgrade the Gradle and push the changes.

angrezichatterbox commented 1 month ago

I have updated the Gradle version. I have to upgrade some dependencies along with it. Due to this, I had to make layout changes to the About activity and the Wikimedia Scribe page I had just created.

andrewtavis commented 1 month ago

Thanks for all the effort here, @angrezichatterbox! 🏆

andrewtavis commented 1 month ago

Will get to the review soon :)