github-actions[bot]
commented
4 weeks ago Thank you for the pull request!
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
Maintainer checklist
-
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-Android repo
-
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
andrewtavis
Contributor checklist
Description
The strings will now be referenced from the i18n folder, which is a subtree of Scribe-i18n. The About page is fully localized, as it was recently created and all the strings were available. The bottom navigation bar is also localized. However, the other pages could not be localized because the strings were not present. As a result, the old strings.xml is still present. I will create a document for the strings currently referenced in the various files from strings.xml.
Related issue
44