Closed angrezichatterbox closed 2 weeks ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Android repo[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
All this is really great, @angrezichatterbox! One thing that I'm noticing is that the dark mode toggle is a bit weird 🤔 It's light mode when I first load the app, but then the toggle is technically on for dark mode. Then when I click it first nothing happens, then clicking it again it goes to the left, and then clicking it again it goes to the right. This is the only toggle that has this issue. Do you want to take a look and then we can merge this in after.
Thanks so much! 🚀
All this is really great, @angrezichatterbox! One thing that I'm noticing is that the dark mode toggle is a bit weird 🤔 It's light mode when I first load the app, but then the toggle is technically on for dark mode. Then when I click it first nothing happens, then clicking it again it goes to the left, and then clicking it again it goes to the right. This is the only toggle that has this issue. Do you want to take a look and then we can merge this in after.
Thanks so much! 🚀
I have fixed the dark mode toggle. :)
Contributor checklist
Description
The pull request implemented Language-based Settings for the enabled language keyboards. I have also changed the min and target sdk and upgraded gradle to 8.5.2 to enable navigation features to app locale settings. I have also moved the files to the Android Studio-generated package.
Related issue
46