search

scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
27 stars 14 forks source link

Kotlin linting workflow #70

Closed andrewtavis closed 1 week ago

andrewtavis commented 2 weeks ago

Terms

Description

This issue would add a .github/workflows/pr_kotlinlint or another similarly named file to the repo with the intent of checking the Kotlin code for the project on each pull request. We'll need to look for a valid GitHub Action to check the code, with this then being set up in a similar way to Scribe-iOS' pr_swiftlint.yaml. We'll maybe need to ignore some rules at first, and then we can slowly fix any syntax/formatting suggestions as work is done 😊

Contribution

Happy to support or get to this eventually myself! This is a good first issue for someone who wants to get into Scribe-Android development a bit! :)

ItsAbhinavM commented 2 weeks ago

I have made a PR for this issue.

andrewtavis commented 1 week ago

Changes made in #79 have finished this up now :) :) We now have ktlint and detekt workflows running on PRs. @angrezichatterbox, let me know if any help is needed making the issues to enable the linting errors we skipped and fix the errors!

Thanks also for the initial work here, @ItsAbhinavM! 😊

angrezichatterbox commented 1 week ago

Changes made in #79 have finished this up now :) :) We now have ktlint and detekt workflows running on PRs. @angrezichatterbox, let me know if any help is needed making the issues to enable the linting errors we skipped and fix the errors!

Thanks also for the initial work here, @ItsAbhinavM! 😊

I will create individual issues for those 4 that we have disabled. :)

andrewtavis commented 1 week ago

Thank you, @angrezichatterbox!