scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
27 stars 14 forks source link

Convert Activities to Fragments and Set Up Common NavHostFragment #71

Closed angrezichatterbox closed 2 weeks ago

angrezichatterbox commented 2 weeks ago

Terms

Description

Currently, the application uses separate activities for different sections, each with its own bottom navigation bar. As a result, navigating between sections requires changing the entire content view and reconstructing the bottom navigation bar every time.

To improve this, We propose a refactor where the bottom navigation bar remains fixed and consistent across the app. Instead of multiple activities, we will convert each section into a fragment. This way, the content view will change according to the selected navigation item, while the bottom navigation bar remains unchanged. This approach will streamline navigation, enhance user experience, and reduce the overhead of recreating the navigation bar with each content switch.

This would help reduce inconsistencies in the bottom navigation bar sizes as well.

The following activities would have been converted to a fragment

There also might be other activities to be modified during the change.

Contribution

I will be happy to take on this issue and would also be willing to help anyone interested in solving this issue :).

angrezichatterbox commented 2 weeks ago

I will be working on this issue.

andrewtavis commented 2 weeks ago

Closed by #74! 🚀 Really amazing work, @angrezichatterbox! Your ability to figure out what's needed and execute is really on display here :)