search

scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
23 stars 25 forks source link

Repository Python code formatting PR check #109

Closed andrewtavis closed 6 months ago

andrewtavis commented 6 months ago

Terms

Description

A great addition to the pull request workflow would be to add a check for code formatting to make sure that all code is formatted with Ruff. We'd want a file in .github/workflows that's called pr_ci.yaml, with the formatting check generally able to be based off of the check from another project I work on.

Contribution

Would be happy to support with this! A contributor has already asked to work on it :)

andrewtavis commented 6 months ago

Hey @Linfye, this is the issue I was saying I can make for you :) If it's still interesting, can you write in here so I can assign? Thanks, and let me know if you have any questions!

Linfye commented 6 months ago

@andrewtavis I have submitted a PR for this issue. And I'm not very proficient in GitHub actions and Ruff, so please let me know if there are any problems. 😊

The running results show that the currently existing code has some formatting problems, and I don't know how to deal with this.

andrewtavis commented 6 months ago

Nice, @Linfye! I'll check out the PR and make the fixes to the current code :) :) We also need to update the maintainer workflow so that we also make sure that these checks pass.

andrewtavis commented 6 months ago

Closed by #111 🥳 Thank you, @Linfye! 😊