scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
23 stars 25 forks source link

checkquery refactory #131

Closed daveads closed 3 months ago

daveads commented 5 months ago

refactored

github-actions[bot] commented 5 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you!

Maintainer checklist

andrewtavis commented 4 months ago

@daveads, do you have any idea what's causing the error here?

============================= test session starts ==============================
platform linux -- Python 3.9.19, pytest-8.1.1, pluggy-1.5.0
rootdir: /home/runner/work/Scribe-Data/Scribe-Data
configfile: pyproject.toml
plugins: cov-5.0.0
collected 63 items / 1 error

==================================== ERRORS ====================================
________________ ERROR collecting tests/load/test_checkquery.py ________________
ImportError while importing test module '/home/runner/work/Scribe-Data/Scribe-Data/tests/load/test_checkquery.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.9.[19](https://github.com/scribe-org/Scribe-Data/actions/runs/8843271753/job/24286017797?pr=131#step:8:20)/x64/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/load/test_checkquery.py:10: in <module>
    from scribe_data.checkquery import (
src/scribe_data/checkquery.py:36: in <module>
    from checkquery_utills.constants import *
E   ModuleNotFoundError: No module named 'checkquery_utills'
=========================== short test summary info ============================
ERROR tests/load/test_checkquery.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
andrewtavis commented 4 months ago

Basic comments on this is that the directory name should be checkquery_utils, not utills. I'm also assuming that we're getting the error that the files aren't able to be found because there's no __init__.py in the new directory :)

Edit: I think that the directory should just be checkquery, and then we can have one word files check.py, etc within it.

andrewtavis commented 4 months ago

Let me know on the above, @daveads! :) I'll pick up more of the review after that 😊

daveads commented 4 months ago

Let me know on the above, @daveads! :) I'll pick up more of the review after that 😊

i will fix this before next week @andrewtavis

andrewtavis commented 4 months ago

Thank you, @daveads! Looking forward to it :)