scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
30 stars 69 forks source link

Added feature pre-commit #141

Closed kush34 closed 5 months ago

kush34 commented 5 months ago

Contributor checklist


Description

Added Pre-commit feature: This feature runs our hooks on every commit to automatically point out issues in code such as missing semicolons, trailing whitespace, and debug statements. Pointing these issues out before code review makes the process easier.

Related issue

github-actions[bot] commented 5 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 5 months ago

No stress on the Mac OS build, btw @kush34 :) We have some problems with those right now.

Generally this all looks good! The JSON files that have all of these changes are going to be moved out of Scribe-Data at some point anyway. Do you want to mark it as ready for review?

andrewtavis commented 5 months ago

Feel free to send along another commit to remove the commented out code that I mentioned here, but aside from that it should be fine :)

andrewtavis commented 5 months ago

I'm going through and trying to close things now, @kush34, so will actually mark as ready and bring it in :) Hope that's ok!