Closed mhmohona closed 3 months ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Data repo[x] The linting and formatting workflow within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Three PRs in a week! Amazing work, @mhmohona! 👏👏👏
Looks like the update_data.py
PR and this one have some minor conflicts, @mhmohona. Do you want us to take a look at those, or fix them yourself? Happy to help!
Looks like some of the SPARQLWrapper commits from #166 are causing the errors here, as seen in the action logs, @mhmohona :) Do you want to take a look at those, or should we fix them?
Extremely sorry for pinging here. I was curious about cli and try some own modification by updating local branches how it works. As a noobish, I really don't know #~ 163
trigger here. :)
Please ignore.
@andrewtavis @wkyoshida will you please have a look at this issue now?
Phew! Finally merged! 💃 Thank you @andrewtavis and @wkyoshida for supporting me.
Contributor checklist
Description
comment for running it
scribe-data query -l english --data-type verbs --output-dir ./output_data --output-type csv
scribe-data query -l english --data-type verbs --output-dir ./output_data --output-type tsv
Related issue
Fixes - #146, #144, #145