scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
30 stars 69 forks source link

Implement CLI query `.csv`, `.tsv` and `sqlite` --output-type functionality via `convert` with timestamp #163

Closed mhmohona closed 3 months ago

mhmohona commented 4 months ago

Contributor checklist


Description

comment for running it

image

Related issue

Fixes - #146, #144, #145

github-actions[bot] commented 4 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 4 months ago

Three PRs in a week! Amazing work, @mhmohona! 👏👏👏

andrewtavis commented 4 months ago

Looks like the update_data.py PR and this one have some minor conflicts, @mhmohona. Do you want us to take a look at those, or fix them yourself? Happy to help!

andrewtavis commented 4 months ago

Looks like some of the SPARQLWrapper commits from #166 are causing the errors here, as seen in the action logs, @mhmohona :) Do you want to take a look at those, or should we fix them?

axif0 commented 3 months ago

Extremely sorry for pinging here. I was curious about cli and try some own modification by updating local branches how it works. As a noobish, I really don't know #~ 163 trigger here. :)

Please ignore.

mhmohona commented 3 months ago

@andrewtavis @wkyoshida will you please have a look at this issue now?

mhmohona commented 3 months ago

Phew! Finally merged! 💃 Thank you @andrewtavis and @wkyoshida for supporting me.