Implement pathlib into the update_data.py file

Jk40git commented 2 months ago

Contributor checklist

[] This pull request is on a separate branch and not the main branch

--- Expand Scribe-Data paths to allow for Windows commands #125

Description

Implement pathlib for the paths to be accurately accessed . Don't know if the pathlib was well adopted. Sure there will be some changes to make

Related issue

ISSUE_NUMBER

github-actions[bot] commented 2 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
[x] The linting and formatting workflow within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

andrewtavis commented 2 months ago

Ok, @Jk40git :) I've merged in the other PRs for the docs and removed the changes from this PR. There's still lots to do here though. I can help with this, but we're looking to replace all instances where there's a path with a / defined via a string with a Path object. Let me know if you'd like to work on this a bit more!

Jk40git commented 2 months ago

Okay Thanks @andrewtavis I will review my suggestion

path should be the src path or scribe-data path?

andrewtavis commented 2 months ago

Should be the Scribe-Data path, @Jk40git :) Feel free to do what you can and @axif0 can also help with the issue 😊

andrewtavis commented 1 month ago

Hey @Jk40git 👋 I'm in the midst of doing some fixes for this and will go ahead and take care of it myself. Thanks so much for the efforts in fixing this!

Hope you're well :)

Jk40git commented 1 month ago

Hey @Jk40git 👋 I'm in the midst of doing some fixes for this and will go ahead and take care of it myself. Thanks so much for the efforts in fixing this!

Hope you're well :)

All right. I am good, been busy those days that's why.

scribe-org / Scribe-Data