Closed axif0 closed 2 months ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Data repo[x] The linting and formatting workflow within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Hey, @andrewtavis hope you are well. Can you please check the pr if you have time?
Hey @axif0 👋 Sorry for the wait here. I've been on and am on an extended vacation, but I'm now in the stage where I can work on some things :) Will check this out!
How can I modify the query to include these compound articles? Are they represented differently in Wikidata? Or am I in the right path?
I think that all's fine, @axif0! Wikidata might just not have the appropriate relationships set yet, but it'll get there 😊 You can go in and edit them yourself, if you'd like to :) Here's the LID for des: https://www.wikidata.org/wiki/Lexeme:L9111.
If you want to find lexemes to edit on Wikidata, you can do a search with L:
at the start of it like this search here.
The one thing that I'm seeing here that's jumping out to me is that translations
has been switched over to a list. I'll check it out a bit more, but this should be ok as I think that a list of dictionaries for each of the language translations also makes sense 😊
Contributor checklist
Description
When i try to run
Scribe-Data/src/scribe_data/language_data_extraction/English/translations$
python3.9 translate_words.py
It gives me this error message,Therefore, after realizing this, i modify the code to match scribe_data_json_export .
I'm extremely sorry for not testing all the languages and not even fully completely test for one language, my potato old pc couldn't handled it. :(
I'm not sure about the Partitive Articles, In french articles, i see SPARQL query for French articles returns: tout, le, un, l', toute, toutes, tous, la, les, une
It's missing:
How can I modify the query to include these compound articles? Are they represented differently in Wikidata? Or am I in the right path?
Related issue
96