Closed henrikth93 closed 2 months ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Data repo[x] The linting and formatting workflow within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Quick note on GitHub, @henrikth93: It's best to request review in these cases rather than assign. I'm not really sure what assign would be in this case, but we don't really use it as a convention. Maybe in the future when we have more than one person working on a PR 😊
Changed the tqdm loop so that it is used together with "with", it enables us to prevent printing the progress bar on a failure/error.
Contributor checklist
Description
Related issue
155