scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
23 stars 25 forks source link

Changed tqdm loop so that we are using "with" #176

Closed henrikth93 closed 2 months ago

henrikth93 commented 2 months ago

Changed the tqdm loop so that it is used together with "with", it enables us to prevent printing the progress bar on a failure/error.

Contributor checklist


Description

Related issue

github-actions[bot] commented 2 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 2 months ago

Quick note on GitHub, @henrikth93: It's best to request review in these cases rather than assign. I'm not really sure what assign would be in this case, but we don't really use it as a convention. Maybe in the future when we have more than one person working on a PR 😊