scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
23 stars 25 forks source link

Hashmap vs if-elif-else #177

Closed to-sta closed 2 months ago

to-sta commented 2 months ago

Contributor checklist


Description

While procrastinating, I came across some code that used a series of if-elif-else blocks. I realized that these could be optimized by using a dictionary (hashmap), which would likely result in better performance.

I updated the README file to include the command for activating the virtual environment using Windows PowerShell.

Related issue

github-actions[bot] commented 2 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 2 months ago

CC @wkyoshida 😊😊😊

andrewtavis commented 2 months ago

I didn't know what I was looking at for a sec when I saw the email alert about the PR 😅 to-sta, Scribe-Data?? 😊

to-sta commented 2 months ago

I didn't know what I was looking at for a sec when I saw the email alert about the PR 😅 to-sta, Scribe-Data?? 😊

I was teaching coding all day yesterday and thought I should also code a bit at the end of the day 😄.

Our issues at activist.org would have consumed more than half an hour 😅. Here I found something fairly simple 👌🏻