scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
30 stars 69 forks source link

Added type hints #181

Closed to-sta closed 3 months ago

to-sta commented 3 months ago

Contributor checklist


Description

Last time, I saw there were some missing type hints in the utils.py file. I just added the rest of them and used Any if it was not clear what will be returned 😄.

Related issue

github-actions[bot] commented 3 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

to-sta commented 3 months ago

Starting from Python 3.9, built-in collection types can be used directly as generics. Since Python 3.9 is used I convert to the built-in list type.

andrewtavis commented 3 months ago

@to-sta, 0c87380 was valid to do given your comment here, correct? I tool out all type imports of List and Dict and just used the built-ins instead :)

to-sta commented 3 months ago

Yeah, that is correct 👌🏻. Here are the release notes, in case you want to read more about.