scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
30 stars 69 forks source link

Issue #135: Update docs with file types and directory indicators #185

Closed lillian-mo closed 2 months ago

lillian-mo commented 2 months ago

Contributor checklist


Description

github-actions[bot] commented 2 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 2 months ago

Hey @lillian-mo 👋 One thing to note from our maintainer checklist is that it looks like your GitHub email isn't set up properly. Normally the commits for the PR should be authored by the same person and the icons should be the same as well. It looks like your Git user.name is set up properly, which indicates that it's likely your email. Can you check that the email you use for GitHub is the same as what you get for git config user.email. From there we can check if the PR fixes itself, or maybe we can reopen it :)

There's no "problem" with the code as it is, but if I were to merge this then your account wouldn't get the commit credit :)

lillian-mo commented 2 months ago

Hey @lillian-mo 👋 One thing to note from our maintainer checklist is that it looks like your GitHub email isn't set up properly. Normally the commits for the PR should be authored by the same person and the icons should be the same as well. It looks like your Git user.name is set up properly, which indicates that it's likely your email. Can you check that the email you use for GitHub is the same as what you get for git config user.email. From there we can check if the PR fixes itself, or maybe we can reopen it :)

There's no "problem" with the code as it is, but if I were to merge this then your account wouldn't get the commit credit :)

Thanks for letting me know! I've configured my git user.email so that it's my personal email here. Hopefully that works :)

andrewtavis commented 2 months ago

Nice! Do you want to reopen the PR regardless? Likely still won't give you the credit as it is :) Is good for us to have you listed as a contributor as well 😊

andrewtavis commented 2 months ago

Hope it's ok that I close with the plan of reopening, @lillian-mo! Just go ahead and send along the same code and I'll quickly bring it in :)