function name upgrade() to upgrade_cli() in upgrade.py

scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction

GNU General Public License v3.0

30 stars 69 forks source link

function name upgrade() to upgrade_cli() in upgrade.py #188

Closed axif0 closed 2 months ago

axif0 commented 2 months ago

Terms

[X] I have searched all open bug reports
[X] I agree to follow Scribe-Data's Code of Conduct

Behavior

In main.py we import upgrade_cli, but in upgrade.py we called upgrade() is it . For that i got error.

andrewtavis commented 2 months ago

Hey @axif0 👋 Do you want to send along a PR for this?

andrewtavis commented 2 months ago

Thanks so much for the issue!

andrewtavis commented 2 months ago

Looks like @pamarthiabhinav already sent along a change 🚀 I'll check this later today :)

axif0 commented 2 months ago

Ah ! already someone Already make an PR!

axif0 commented 2 months ago

@andrewtavis, in version currently the message looksScribe-Data vScribe-Data v3.3.0 (Update available: vScribe-Data v3.0.1)\nTo update: pip scribe-data --upgrade .

Shouldn't it look like Scribe-Data v3.3.0 (Update available: v3.3.1)\nTo update: pip scribe-data --upgrade

Can i work on this?

andrewtavis commented 2 months ago

Yes, @axif0, that makes sense :) You can also change Update to Upgrade :)

andrewtavis commented 2 months ago

Thank you!

pamarthiabhinav commented 2 months ago

@axif0 Apologies if you're working on this. But thanks for giving me a start for my contribution to the Scribe-Org.

pamarthiabhinav commented 2 months ago

@andrewtavis PR #189 is ready for review. Check it out!

axif0 commented 2 months ago

@pamarthiabhinav it's ok. Chill. Welcome to Scribe-Org. We have great mentors like @andrewtavis and you can learn a lot from him.