search

scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
23 stars 25 forks source link

Modify Upgrade Message #190

Closed axif0 closed 1 month ago

axif0 commented 1 month ago

Terms

Behavior

In Upgrade currently the message looks Scribe-Data vScribe-Data v3.3.0 (Update available: vScribe-Data v3.0.1)\nTo update: pip scribe-data --upgrade .

Shouldn't it look like Scribe-Data v3.3.0 (Update available: v3.3.1)\nTo update: pip scribe-data --upgrade in here If it is. @andrewtavis Can i work on this?

andrewtavis commented 1 month ago

Sounds good, @axif0! Feel free to change Update to Upgrade as well :)

axif0 commented 1 month ago

@andrewtavis If you don't mind Should I add cli test cases for version check? if yes, then where should I add it? I think is best option to put test file is here, https://github.com/scribe-org/Scribe-Data/tree/main/tests

I'll change the version message to Scribe-Data v3.3.0 (Update available: Scribe-Data v3.3.1)\nTo update: pip scribe-data --upgrade

andrewtavis commented 1 month ago

Closed by #191 🚀 Thank you for opening all of the issues today and getting to the fixes for them so quickly, @axif0! 😊