scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
30 stars 69 forks source link

fix: version message, add test for version #191

Closed axif0 closed 2 months ago

axif0 commented 2 months ago

Contributor checklist


Description

Related issue

github-actions[bot] commented 2 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 2 months ago

Yes, I think that the way that @axif0 has it set up works well :) If the other tests in #170 could be split and added to tests/cli like the one here that would be great!

andrewtavis commented 2 months ago

Thanks for the work here both of you! 😊