Data Type Metadata with QID

scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction

GNU General Public License v3.0

30 stars 69 forks source link

Data Type Metadata with QID #194

Closed axif0 closed 1 month ago

axif0 commented 2 months ago

Terms

[X] I have searched open and closed issues
[X] I agree to follow Scribe-Data's Code of Conduct

Issue

data_type_metadata should bear qid. data-types seams to be redundant.

andrewtavis commented 2 months ago

If you'd like to send along a change for this, @axif0, then that would be fine, but the issue is that we decided that we're not going to do QIDs for data types as some languages are using different ones. But for now it's fine if you want to include the QIDs in the data_type_metadata part and then load that in and use it instead of data_type_to_qid :)

andrewtavis commented 1 month ago

Closed by #199 😊 Thanks for diagnosing the issue and solving it so quickly, @axif0!