scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
23 stars 25 forks source link

minor redundant code fix #195

Closed axif0 closed 3 weeks ago

axif0 commented 3 weeks ago

Contributor checklist


Description

We can reuse cli_utils code in list.py

github-actions[bot] commented 3 weeks ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 3 weeks ago

Can you check out the tests here, @axif0 :) I'm not sure that we can import variables from another files that are defined with with ... as .... Maybe you could remove those and just have this be to remove the repeat print statement? Happy to hear your thoughts though!

axif0 commented 3 weeks ago

@andrewtavis My bad I forgot to check the tests. Can you please check it?