Closed axif0 closed 3 weeks ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Data repo[x] The linting and formatting workflow within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Can you check out the tests here, @axif0 :) I'm not sure that we can import variables from another files that are defined with with ... as ...
. Maybe you could remove those and just have this be to remove the repeat print statement? Happy to hear your thoughts though!
@andrewtavis My bad I forgot to check the tests. Can you please check it?
Contributor checklist
Description
We can reuse cli_utils code in list.py