scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
23 stars 25 forks source link

Fix paths in test_check_query.py Windows compatible #198

Closed axif0 closed 3 weeks ago

axif0 commented 3 weeks ago

Contributor checklist


Description

Added a function normalize_path . Here it takes a file system path as an input and returns a "normalized" version of that path. image

Related issue

github-actions[bot] commented 3 weeks ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 3 weeks ago

Hey @axif0 👋 Generally is looking good and I really like the inclusion of marks! Thanks for helping to organize the code :)

Would it be possible to leverage pathlib for this instead of os. In this way it'd be consistent with the rest of the project :)

axif0 commented 3 weeks ago

@andrewtavis thank you so much. pathlib is more realistic to use here.

@mhmohona In my windows environment, I got no error in testing, for double checking can you please verify it by running the wikidata test ?

andrewtavis commented 3 weeks ago

Thanks so much for the quick fixes here, @axif0! :)

mhmohona commented 3 weeks ago

Thanks for the quick reaction to the comments, @axif0! @mhmohona, do let us know if you're seeing anything that needs to be done about the recent commits. For now we're good to merge 😊

@andrewtavis I just checked. It seems things are working fine, without any error on Windows. ✨

and @axif0, good work. 👏🏾