Closed axif0 closed 3 weeks ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Data repo[x] The linting and formatting workflow within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Hey @axif0 👋 Generally is looking good and I really like the inclusion of marks! Thanks for helping to organize the code :)
Would it be possible to leverage pathlib for this instead of os. In this way it'd be consistent with the rest of the project :)
@andrewtavis thank you so much. pathlib is more realistic to use here.
@mhmohona In my windows environment, I got no error in testing, for double checking can you please verify it by running the wikidata test ?
Thanks so much for the quick fixes here, @axif0! :)
Thanks for the quick reaction to the comments, @axif0! @mhmohona, do let us know if you're seeing anything that needs to be done about the recent commits. For now we're good to merge 😊
@andrewtavis I just checked. It seems things are working fine, without any error on Windows. ✨
and @axif0, good work. 👏🏾
Contributor checklist
Description
Added a function
normalize_path
. Here it takes a file system path as an input and returns a "normalized" version of that path.Related issue
197