scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
30 stars 69 forks source link

qid & testing add #199

Closed axif0 closed 1 month ago

axif0 commented 1 month ago

Contributor checklist


Description

moved data_type_metadata part and then load that in and use it instead of data_type_to_qid. Also, add tests for get_qid_by_input.

image image

Related issue

github-actions[bot] commented 1 month ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 1 month ago

Thanks for the PR, @axif0! I'll try to bring it in later :)