Closed mhmohona closed 1 month ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Data repo[x] The linting and formatting workflow within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
This change in test_get.py
file has been made to include the overwrite
parameter in the test's expected calls so they match the actual calls to query_data
, resolving the AssertionError
caused by mismatched arguments in CI test.
Minor changes in 4cbc502 as I felt like the CLI was a bit too verbose. It was saying it was going to do something multiple times. The path for exporting JSONs also wasn't working properly as it needs to be absolute. @mhmohona, do you want to take a look at some of these changes and we can discuss how to go from here? Multiple data types is also working, so we're generally good in those regards :)
Contributor checklist
Description
Related issue
202