scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
30 stars 69 forks source link

Fix more bug in CLI - Interactive Learning module #204

Closed mhmohona closed 1 month ago

mhmohona commented 1 month ago

Contributor checklist


Description

Related issue

github-actions[bot] commented 1 month ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

mhmohona commented 1 month ago

This change in test_get.py file has been made to include the overwrite parameter in the test's expected calls so they match the actual calls to query_data, resolving the AssertionError caused by mismatched arguments in CI test.

andrewtavis commented 1 month ago

Minor changes in 4cbc502 as I felt like the CLI was a bit too verbose. It was saying it was going to do something multiple times. The path for exporting JSONs also wasn't working properly as it needs to be absolute. @mhmohona, do you want to take a look at some of these changes and we can discuss how to go from here? Multiple data types is also working, so we're generally good in those regards :)