scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
30 stars 69 forks source link

workflow fix #308

Closed axif0 closed 1 month ago

axif0 commented 1 month ago

Contributor checklist

github-actions[bot] commented 1 month ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 1 month ago

There seems to be some confusion here, @axif0 :) Big thing we're looking for here is "Is this the first PR from the user?", and if so we want to show all of the checkboxes. If it's not their first PR, then we want to show only the second two. We still want maintainers to check off that the linting changes are good and that the changelog has been updated. I think that actions/first-interaction would be the easiest way to do this :)

axif0 commented 1 month ago

@andrewtavis Sorry, I was confused for this line If it is the first pull request, then we would want the first checkbox to be included, and if not, then the first checkbox should be removed. on the issue previously. Since actions/first-interaction requires either issue-message or pr-message to be set. we can set,

 - name: Check if this is the user's first PR
        pr-message: " ...  "
- name: Comment PR (First PR)
        if: steps.first_interaction.outputs.first_pr == 'true'
- name: Comment PR (Not First PR)
        if: steps.first_interaction.outputs.first_pr == 'false'

Here, for the first PR it gives 2 messages. Check if this is the user's first PR along with Comment PR (First PR). are we okay with that?

andrewtavis commented 1 month ago

Yes, this sounds great @axif0 :) Let's implement this and then merge it and then you can raise a PR to test if we're not getting the first checkbox anymore :)

axif0 commented 1 month ago

Hello @andrewtavis, I checked First interaction pull#3 and furthermore pull#4 works perfectly. I searched for steps.first_interaction.outputs.first_pr or similar types of variable that returns if first_interaction or not. if it is then I could make one message but sadly I can't find any.

andrewtavis commented 1 month ago

This makes sense though, @axif0 :) Thanks much!