Closed axif0 closed 1 month ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Data repo[x] The linting and formatting workflow within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
There seems to be some confusion here, @axif0 :) Big thing we're looking for here is "Is this the first PR from the user?", and if so we want to show all of the checkboxes. If it's not their first PR, then we want to show only the second two. We still want maintainers to check off that the linting changes are good and that the changelog has been updated. I think that actions/first-interaction would be the easiest way to do this :)
@andrewtavis Sorry, I was confused for this line If it is the first pull request, then we would want the first checkbox to be included, and if not, then the first checkbox should be removed.
on the issue previously. Since actions/first-interaction
requires either issue-message or pr-message to be set. we can set,
- name: Check if this is the user's first PR
pr-message: " ... "
- name: Comment PR (First PR)
if: steps.first_interaction.outputs.first_pr == 'true'
- name: Comment PR (Not First PR)
if: steps.first_interaction.outputs.first_pr == 'false'
Here, for the first PR it gives 2 messages. Check if this is the user's first PR
along with Comment PR (First PR)
. are we okay with that?
Yes, this sounds great @axif0 :) Let's implement this and then merge it and then you can raise a PR to test if we're not getting the first checkbox anymore :)
This makes sense though, @axif0 :) Thanks much!
Contributor checklist
Description
Here,
steps.pr_count.outputs.result
gets all the merged PR author. and checks if it is 0 (first or not). if o then it'll show the maintainer checklist.300