github-actions[bot]
commented
1 month ago Thank you for the pull request!
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
Maintainer checklist
-
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-Data repo
-
[x] The linting and formatting workflow within the PR checks do not indicate new errors in the files changed
-
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Contributor checklist
Description
Addition of Japanese Prepositions Query: Created a new SPARQL query file under src/scribe_data/language_data_extraction/Japanese/prepositions/query_prepositions.sparql to fetch prepositions for Japanese, aligned with the structure used for other languages.
Addition of Japanese Adverbs Query: Added a new SPARQL query file under src/scribe_data/language_data_extraction/Japanese/adverbs/query_adverbs.sparql to capture adverbs in Japanese, filtering by "ja-hira" (Japanese Hiragana script).
Testing: I manually checked the queries by executing them to confirm that they return valid results from the dataset at query.wikidata.org
Related issue
301