scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
30 stars 69 forks source link

Added functionality to convert data to CSV/TSV and JSON and vice versa. #329

Closed john-thuo1 closed 1 month ago

john-thuo1 commented 1 month ago

Contributor Checklist

I tested the changes by running the CLI commands and verifying that the output matched the expected formats. I want to get feedback on the approaches before implementing the code tests and the SQLite conversion support

Related issue

github-actions[bot] commented 1 month ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 1 month ago

@mhmohona, if you have time, it'd be great if you could take a first look at the changes to convert.py :) Let me know if I should check it from the start!

andrewtavis commented 1 month ago

@john-thuo1, is there a way that we can get the commit history here cleaned up a bit? It's hard for us to review this as I can't tell what the changes are that are in here and already on main. What might make sense would be to make a new branch from the current version of main and add your changes to that? Then open a new PR?

john-thuo1 commented 1 month ago

@john-thuo1, is there a way that we can get the commit history here cleaned up a bit? It's hard for us to review this as I can't tell what the changes are that are in here and already on main. What might make sense would be to make a new branch from the current version of main and add your changes to that? Then open a new PR?

Alright. Apologies for that. Still getting the hang of cherry-picking.

andrewtavis commented 1 month ago

Hey it's hard stuff, @john-thuo1! Thanks for opening #338 :)