Fix: Check Before Deleting File in Workflow

[SethiShreya]

Terms

• [X] I have searched open and closed feature requests
• [X] I agree to follow Scribe-Data's Code of Conduct

Description

Currently, the workflow deletes the file first and then extracts the data. This approach causes an issue where if an error occurs during data extraction, the previous file is already deleted and no new data is added, resulting in data loss.

Steps to Reproduce:

• Run the following command: scribe-data get --lang german -dt nouns

• Carefully observe the workflow: a. The file is deleted first. b. Then the data extraction process begins. c. If any error occurs during the data extraction, no new data is added, and the previous file is already deleted.

Expected Behavior: The system should first verify whether the data extraction process is successful before deleting the file. If the data extraction is error-free, then the file should be deleted.

Proposed Fix:

• Add a checking mechanism before deleting the file.
• Only proceed with file deletion if the data extraction process completes successfully without errors.

Impact: This will prevent unnecessary data loss in case of errors during the extraction phase.

Contribution

No response

[andrewtavis]

Thanks for the issue, @SethiShreya!

[andrewtavis]

@SethiShreya: Do you think that including totals lexemes regardless of data type in the total output makes sense? maybe as the first row of the table? Let me know and I can make an issue for it :)

[Otom-obhazi]

can i help??