Open andrewtavis opened 2 hours ago
Hi, @andrewtavis , @DeleMike and @catreedle, Can I also contribute to this issue?
Thanks @andrewtavis. I would love to be assigned to this issue. I would get started on it soon :)
Let's definitely let @DeleMike and @catreedle do the PRs for here and #340, @KesharwaniArpita, as @DeleMike was the writer of the snippets and @catreedle did the initial reviews :) I'll let them say if they want support here, but maybe you could do #341?
I was thinking, @catreedle , do you think we could work together on this issue?
we could break this into two PRs, one for checking language appropriateness and the other for data type appropriateness? is this okay? @andrewtavis
I was thinking that #341 could be suited for @KesharwaniArpita ? ... it might be easier since @KesharwaniArpita was not in our initial discussions. That issue seems self-explanatory. what do you think? @catreedle
How about this @andrewtavis ?
Ok, I get it. Thanks for telling me about the discussion βΊοΈ
Let's definitely let @DeleMike and @catreedle do the PRs for here and #340, @KesharwaniArpita, as @DeleMike was the writer of the snippets and @catreedle did the initial reviews :) I'll let them say if they want support here, but maybe you could do #341?
Ah yes! I did not see this!! You are right. we'll wait for feedback from @catreedle if she's comfortable with this :)
Assigning @KesharwaniArpita in so far as it'd be great if you all would discuss the implementation together, but as @KesharwaniArpita's on #341 my assumption is that the coding for this and #340 are done by @DeleMike and @catreedle π
I'll happily be the learner here!!! π π Thanks for considering me!!!!
Terms
Description
This issue would create a new workflow in .github/workflows called
check_query_identifiers.yaml
that would call a Python script that would check all queries within thelanguage_data_extraction
directory to make sure that the identifiers used within them are appropriate. We can put these scripts in a new .github/workflows directory calledcheck
. The scripts would be:/src/scribe_data/check/check_query_identifiers.py
would check all queries in thelanguage_data_extraction
directory for two things?lexeme dct:language wd:Q12345
in the query appropriate given the directory that it's in?wikibase:lexicalCategory wd:Q12345
?Queries that fail these conditions should be added to a list and shown to the user in an output of the script and thus the workflow. Something like:
A code snippet that could help with this comes from #330:
Contribution
Happy to support, answer questions and review as needed!
CC @DeleMike and @catreedle :)