Closed mhmohona closed 6 months ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-Data repo[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
@andrewtavis, Thank you for your guideline. I will keep it in mind in future.
so after merging this PR, now I am seeing texts in sidebar becomes white when I hover mouse on them -
But when I am running locally it looks like this -
Would make sense to do an issue for this, @mhmohona! Thanks for checking!
@andrewtavis, instead of issue, I submitted the #100, hopefully which is gonna fix the problem.
Thank you! I'll take a look as soon as I can :)
Contributor checklist
Description
Changes made:
ScribeDataLogo.png
(logo) to the_static
folder.conf.py
to includehtml_logo
and reference the new logo.custom.css
with styles for sidebar header color, text color, and logo padding.Tested locally to ensure that the layout appears correctly and that the logo is properly integrated within the sidebar.
Related issue