search

scribe-org / Scribe-Data

Wikidata, Wiktionary and Wikipedia language data extraction
GNU General Public License v3.0
23 stars 25 forks source link

Add back in visibility of the version number to the docs sidebar #95

Closed andrewtavis closed 6 months ago

andrewtavis commented 6 months ago

Terms

Behavior

One issues from the most recent changes to the documentation layout to add in the logo in #90 was that the version number is now not visible. As seen in the image below, there's a space between the logo and search bar where the version is:

Screenshot_2024-03-09 17 24 18

We could either change the text to black, or we can remove it entirely, but the former would be preferable :)

andrewtavis commented 6 months ago

CC @mhmohona, would you like to work on this?

mhmohona commented 6 months ago

Yes please! 😅

mhmohona commented 6 months ago

@andrewtavis, so just to be clear, its the screenshot of the logo before my PR was merged. image

So I am seeing here the version was not been added previously.

However, I am add about version info and and PR for this issue is on the way!

andrewtavis commented 6 months ago

Hmmmm, this is very interesting, @mhmohona 🤔 I think it's displayed differently based on the screen size or something, as I've always had the version number under the title on mine even before the logo was there :)

mhmohona commented 6 months ago

Sorry, my bad. It was my mistake 😬 sent fix in #100.

andrewtavis commented 6 months ago

No stress whatsoever! Thanks for the quick fix!

andrewtavis commented 6 months ago

Version number is visible now after c6d79f4 😊 We needed to make the text black for it to show up :)