search

scribe-org / Scribe-iOS

iOS app with keyboards for language learners
https://apps.apple.com/app/scribe-language-keyboards/id1596613886
GNU General Public License v3.0
128 stars 78 forks source link

Add demonstrative pronouns to German case declination displays #249

Closed andrewtavis closed 1 year ago

andrewtavis commented 2 years ago

Terms

Description

This issue would add declinations for demonstrative pronouns (this and these) into the display that users see when the type a preposition and press the case annotation. This would use the 2x2 forms display with masculine in the top left, feminine in the top right, neutral in the bottom left, and plural in the bottom right (to match other table forms).

The various declinations can be found on this website: https://deutschegrammatik20.de/pronomen/demonstrativpronomen-2/demonstrativpronomen/

Contribution

I'd be happy to support someone in implementing this, or will work on it in the coming weeks 😊 The main thing will be creating the dictionaries, and then adding references to them by adding cases to the following enum: https://github.com/scribe-org/Scribe-iOS/blob/00b0fc4dd9751bd9162db3682920a25438956eee/Keyboards/LanguageKeyboards/German/DECommandVariables.swift#L80

muntasir14 commented 1 year ago

Hi, I would like to handle the issue.

andrewtavis commented 1 year ago

Hi @muntasir14! Thanks for your offer to help :) Will assign you now, and let me know if you need any assistance with this 😊

andrewtavis commented 1 year ago

@muntasir14, d1083ca fixed a minor spelling mistake I saw after merging and also did some formatting so the block that triggers the 2x2 display's a bit easier to read :) Really appreciate this contribution 🙏 I actually just did a meetup for Scribe tonight and the pronoun display was a big hit! One of the factors in us getting hack of the night 😉😊

Glad to have you working on #273 🥳 Would be very happy to get more commits from you!

andrewtavis commented 1 year ago

@muntasir14 , one thing to check is whether your email is set up correctly for GitHub. You're currently not listed in the contributors. This Stack Overflow question talks about it :) Just want to make sure you're getting credit for your work 😊

muntasir14 commented 1 year ago

Hi, the configured email was not added to my GitHub account. I've added it now. Thank you

On Wed, Mar 29, 2023 at 4:39 AM Andrew Tavis McAllister < @.***> wrote:

@muntasir14 https://github.com/muntasir14 , one thing to check is whether your email is set up correctly for GitHub. You're currently not listed in the contributors https://github.com/scribe-org/Scribe-iOS/graphs/contributors. This Stack Overflow question https://stackoverflow.com/questions/40644933/not-showing-as-a-contributor-on-github talks about it :) Just want to make sure you're getting credit for your work 😊

— Reply to this email directly, view it on GitHub https://github.com/scribe-org/Scribe-iOS/issues/249#issuecomment-1487695731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJVPLJJDOTL6H33RZ7M4Q3W6NSA3ANCNFSM6AAAAAARSHOSSU . You are receiving this because you were mentioned.Message ID: @.***>

andrewtavis commented 1 year ago

Wonderful :) Hopefully you'll be showing up in the contributors list in no time 🤞