scribe-org / Scribe-iOS

iOS app with keyboards for language learners
https://apps.apple.com/app/scribe-language-keyboards/id1596613886
GNU General Public License v3.0
128 stars 78 forks source link

Add in pre-commit hook for running swiftlint on codebase #450

Closed andrewtavis closed 4 months ago

andrewtavis commented 5 months ago

Terms

Description

This issue would explore the potential of adding in pre-commit to the repo and using it to run our SwiftLint checks before commits. We'd want a hook that runs swiftlint --strict before all commits so that warnings are also triggered.

Contribution

Happy to support on this or get to it myself eventually! This would be a good first issue for someone who has a bit of Python or pre-commit setup experience :)

andrewtavis commented 4 months ago

Note that there appears to be a file for this in SwiftLint here :) We'd maybe also need to add --strict to the execution.

andrewtavis commented 4 months ago

Closed by #460 🥳 Thanks for this, @henrikth93! Such a great step towards very maintainable code :)