scribe-org / Scribe-iOS

iOS app with keyboards for language learners
https://apps.apple.com/app/scribe-language-keyboards/id1596613886
GNU General Public License v3.0
131 stars 79 forks source link

467 standardize app hints implementation to assure consistent locations #473

Closed Mashtaleralia closed 4 months ago

Mashtaleralia commented 4 months ago

Contributor checklist


Description

Related issue

github-actions[bot] commented 4 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 4 months ago

Hey @Mashtaleralia 👋 Thanks for the PR! Would be great to get a bit of a description for it, but then the change is quite apparent 😊 This is actually a good idea, that maybe the shift is being caused because the devices without a home button have a bit more of a distance from the top of the screen that needs to be accounted for (assuming given the change). Let me check it out and see if it's working :)

Mashtaleralia commented 4 months ago

thanks!