Closed Mashtaleralia closed 4 months ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
git config user.email
in their local Scribe-iOS repo[x] The linting and formatting workflows within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Hey @Mashtaleralia 👋 Thanks for the PR! Would be great to get a bit of a description for it, but then the change is quite apparent 😊 This is actually a good idea, that maybe the shift is being caused because the devices without a home button have a bit more of a distance from the top of the screen that needs to be accounted for (assuming given the change). Let me check it out and see if it's working :)
thanks!
Contributor checklist
Description
Related issue
ISSUE_NUMBER
https://github.com/scribe-org/Scribe-iOS/issues/467