github-actions[bot]
commented
3 months ago Thank you for the pull request!
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
Maintainer checklist
-
[x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-iOS repo
-
[x] The linting and formatting workflows within the PR checks do not indicate new errors in the files changed
-
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
andrewtavis
Contributor checklist
Description
Adds in new localizations from Scribe-i18n and fixes some code that messed up the files through Xcode's automatic generation
Xcode also orders the languages for a specific key alphabetically, currently English is always the last. This needs to be changed within Scribe-i18n's conversion scripts though. It also puts the state for any language names that we don't have localizations for as "stale", even if they're being used within the app. A fix for this would be to create variables for the names of all languages, but these would pretty much never get used, opinions on this @andrewtavis @henrikth93?