refactor(swiftlint): enable for_where and fix violations

[jon-tous]

Contributor checklist

• [X] This pull request is on a separate branch and not the main branch

---

Description

Removed for_where as a disabled rule from .swiftlint.yml and fixed all errors for it in the codebase.

After removing for_where from disabled_rules, I fixed all 6 violations by removing the if statement within each affected for-loop, and moving the condition into a where clause on the for-loop itself. This is the preferred syntax for SwiftLint enforced by the for_where rule, and this refactor does not affect functionality. After making those changes, no SwiftLint warnings were shown, and running swiftlint --strict in the project root confirmed: Done linting! Found 0 violations, 0 serious in 86 files. This rule would now be enforced by SwiftLint to prevent further violations from entering the codebase.

I verified on the iPhone 15 Pro simulator and iPad Pro 13-inch simulator (both iOS 17.5) that the app builds and runs as usual following this change and the affected constraints look as normal. I verified with one of these fixed violations that this refactor does not affect which elements run the body of loop/conditional, using print statements and comparing the values of all the possible constraints before vs. after the refactor.

Related issue

• 428

[github-actions[bot]]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• [x] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo

• [x] The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• [x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)