scribe-org / Scribe-iOS

iOS app with keyboards for language learners
https://apps.apple.com/app/scribe-language-keyboards/id1596613886
GNU General Public License v3.0
130 stars 79 forks source link

Hebrew Keyboard update to HEInterfaceKeyboard.swift #495

Closed DanielGevaZA closed 2 months ago

DanielGevaZA commented 2 months ago

Contributor checklist


Description

Related issue

github-actions[bot] commented 2 months ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 2 months ago

The above comments are the main things here, @DanielGevaZA! From there it looks like you also have some swiftlint errors that need to be attended to. Let me know if there's anything I can do to help or if you have any questions! Thanks for this! :)

andrewtavis commented 2 months ago

Just did a quick format of the file and translated some words, but could you check that what I put in there is correct for things like "Translate", "Conjugate", "Conjugation: ", "Plural", and "Already in plural form"? Aside from that, is there a different version of a colon for Hebrew? So for "Conjugation: " I did the translation, the colon on the left and a space after it? This would be the header within the command bar when a user is selecting a conjugation for a given verb :)

Let me know on the above and we'll be able to bring this in! Note that if you want to make changes here, first pull my most recent commit down. I figure you know this, but just want to make sure 😇

DanielGevaZA commented 2 months ago

Will check the spelling/translation now. Thanks for helping with the formatting.

DanielGevaZA commented 2 months ago

All looks good with the translations, Yes you can use the colon in hebrew but it is less common. Isnt really an alternative so a : can be used.

andrewtavis commented 2 months ago

Very happy to help with the formatting, and thanks for checking the changes! :)