Closed henrikth93 closed 6 days ago
The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!
[x] The linting and formatting workflows within the PR checks do not indicate new errors in the files changed
[x] The CI unit test workflows within the PR checks do not indicate new errors in the files changed
[x] The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)
Tests are passing locally, so I'll take a better look at this soon :) @henrikth93: Would you be able to bring this down and do one minor edit to get the text for the Wikimedia and Scribe page a bit closer to the top like the rest of the About pages? I feel like we may have increased the distance between the top of the card and the text, and this should be reverted. The privacy policy and third party license pages have good spacing from the text to the top of the card, so maybe investigate the difference and re-apply to the Wikimedia and Scribe page?
Tests are passing locally, so I'll take a better look at this soon :) @henrikth93: Would you be able to bring this down and do one minor edit to get the text for the Wikimedia and Scribe page a bit closer to the top like the rest of the About pages? I feel like we may have increased the distance between the top of the card and the text, and this should be reverted. The privacy policy and third party license pages have good spacing from the text to the top of the card, so maybe investigate the difference and re-apply to the Wikimedia and Scribe page?
Sure
Thank you! We can merge this and figure out the tests later if need be, but I'll also look into it over the weekend :)
This commit will remove the corner image view and the icon image view.
Contributor checklist
xcodebuild
andswiftlint --strict
commands as directed in the testing section of the contributing guideDescription
Related issue
514