scribe-org / Scribe-iOS

iOS app with keyboards for language learners
https://apps.apple.com/app/scribe-language-keyboards/id1596613886
GNU General Public License v3.0
131 stars 79 forks source link

Remove corner image and icon image #515

Closed henrikth93 closed 6 days ago

henrikth93 commented 1 week ago

This commit will remove the corner image view and the icon image view.

Contributor checklist


Description

Related issue

github-actions[bot] commented 1 week ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 1 week ago

Tests are passing locally, so I'll take a better look at this soon :) @henrikth93: Would you be able to bring this down and do one minor edit to get the text for the Wikimedia and Scribe page a bit closer to the top like the rest of the About pages? I feel like we may have increased the distance between the top of the card and the text, and this should be reverted. The privacy policy and third party license pages have good spacing from the text to the top of the card, so maybe investigate the difference and re-apply to the Wikimedia and Scribe page?

henrikth93 commented 1 week ago

Tests are passing locally, so I'll take a better look at this soon :) @henrikth93: Would you be able to bring this down and do one minor edit to get the text for the Wikimedia and Scribe page a bit closer to the top like the rest of the About pages? I feel like we may have increased the distance between the top of the card and the text, and this should be reverted. The privacy policy and third party license pages have good spacing from the text to the top of the card, so maybe investigate the difference and re-apply to the Wikimedia and Scribe page?

Sure

andrewtavis commented 1 week ago

Thank you! We can merge this and figure out the tests later if need be, but I'll also look into it over the weekend :)