Add adjective-preposition annotation support

scribe-org / Scribe-iOS

iOS app with keyboards for language learners

https://apps.apple.com/app/scribe-language-keyboards/id1596613886

GNU General Public License v3.0

121 stars 74 forks source link

Add adjective-preposition annotation support #86

Open andrewtavis opened 2 years ago

andrewtavis commented 2 years ago

Terms

[X] I have searched open and closed feature requests
[X] I agree to follow Scribe-iOS' Code of Conduct

Description

Another feature that Scribe should add is annotating adjectives with what prepositions follow them. This would be helpful for German and other languages. Currently Wikidata doesn’t have prepositions linked to adjectives, but this data can be added, and this feature could then be added in a similar way to noun-gender annotation.

This issue is for tracking the support of adjective-preposition data on Wikidata, as well as implementing the feature when enough data is available.

This issue is linked to #77 as the same functionality would work for this feature where an adjective could be followed by more than one preposition

marekviktor commented 11 months ago

I would like to contribute on this project with this issue.

andrewtavis commented 11 months ago

Hey @marekviktor 👋 Really appreciate your interest to help with this! Big thing is that right now the data isn't available for this, so we'd need to either add it ourselves or ask the Wikidata community for support. Would you have interest in working on this as well?

marekviktor commented 11 months ago

And is there something else I can help with? Something with UI and good first issue will be perfect for me.

andrewtavis commented 11 months ago

Thanks for your dedication here @marekviktor :) :) I'm thinking about it a bit, would something like #334 be of interest? This is not going to be fully implemented for some time as we'd need the Scribe-Server project to be fully up and running (couple months), but you could be working on the menu in the meantime? A first step would be adding in the button to jump to the download interface as is specified in the image in that issue, and then the next step would be working on this interface here. Lots of work to do, but we could break it up 😊

Let me know what you think! If it sounds good, feel free to write into the issue 🙃

marekviktor commented 10 months ago

andrewtavis so can you assign me to https://github.com/scribe-org/Scribe-iOS/issues/334?

andrewtavis commented 10 months ago

Hey @marekviktor 👋 Can you write in #334 and I'll assign you? I can't assign until you've interacted with the issue :)