search

scribu / wp-posts-to-posts

Efficient many-to-many connections between posts, pages, custom post types, users.
http://wordpress.org/plugins/posts-to-posts/
969 stars 260 forks source link

Optional parameter deprecation notices in PHP 8 #578

Open iandunn opened 1 year ago

iandunn commented 1 year ago 
> wp plugin list
Deprecated: Optional parameter $formdata declared before required parameter $nonce is implicitly treated as a required parameter in wp-content/plugins/posts-to-posts/vendor/scribu/scb-framework/Forms.php on line 65
Deprecated: Optional parameter $file declared before required parameter $args is implicitly treated as a required parameter in wp-content/plugins/posts-to-posts/vendor/scribu/scb-framework/Cron.php on line 24
+----------------------------------+----------+--------+---------+
| name                             | status   | update | version |
+----------------------------------+----------+--------+---------+
| posts-to-posts                   | active   | none   | 1.7     |

https://php.watch/versions/8.0/deprecate-required-param-after-optional

Related #576

hirasso commented 1 year ago

These deprecations are actually inside scb-framework, this plugin depends on.

I created a PR to fix them over there. As soon as that is merged, we can update the composer version of scb-framework for wp-posts-to-posts.