search

scribu / wp-scb-framework

Utilities for speeding up WordPress plugin and theme development
https://github.com/scribu/wp-scb-framework/wiki
220 stars 55 forks source link

Fix deprecated hook contextual_help, use current_screen instead #56

Closed jhotadhari closed 4 years ago

jhotadhari commented 4 years ago

Hope it won't break anything.

Is there a chance that wp-posts-to-posts will be updated with latest version of wp-scb-framework?

dikiyforester commented 4 years ago

Hi @jhotadhari! Did you check #54? The issue with #56 that if some class extends _contextual_help() with two arguments it will lead to fatal error.

andrzejpiotrowski commented 4 years ago

The issue with #56 that if some class extends _contextual_help() with two arguments it will lead to fatal error. Just logged in to write +- the same 😅

jhotadhari commented 4 years ago

Hi, oohh yes, true. That will lead to fatal error.

Somehow didn't see #54. Just thought about an wrapper function. Great #54 _contextual_help_compat does it already. Thanks