search

scribusproject / scribus

Mirror of official Scribus SVN (however you should really use SVN at svn://scribus.net) (http://bugs.scribus.net ← Submit PRs & Bugs)
http://scribus.net
Other
400 stars 107 forks source link

for loop defect #173

Closed maddin200 closed 11 months ago

maddin200 commented 1 year ago

scribus/fonts/cff.cpp line 1551

Code:

for (uint gid = 0; gid <= maxGid; ++gid); // <-- additional sign
{
    if (codes.contains(gid))
        result.append(codes[gid]);
    else
        result.append('\0'); // this is probably not correct
}
aoloe commented 11 months ago

oooops!

i've posted it to the real scribus bug tracker as https://bugs.scribus.net/view.php?id=17021.