scribusproject / scribus

Mirror of official Scribus SVN (however you should really use SVN at svn://scribus.net) (http://bugs.scribus.net ← Submit PRs & Bugs)
http://scribus.net
Other
406 stars 109 forks source link

port the scripter to python3 and pyqt5 #2

Open luzpaz opened 9 years ago

luzpaz commented 9 years ago

From @aoloe on August 1, 2014 9:48

the new scripter is compiling again, but crashes on boot.

the reason is probably that it has to be ported to pyqt5 (and then also to python3) to be compatible with scribus' move to qt5.

i have created a scripter branch and i propose that we discuss implementation details and issues in this ticket / issue tracker.

Copied from original issue: scribusproject/scribus-old-to-be-deleted#4

luzpaz commented 9 years ago

From @aoloe on August 1, 2014 9:50

btw, everybody is welcome to join the effort, if possible with small incremental patches and communication in advance on what you are up to...

luzpaz commented 9 years ago

From @QuLogic on August 3, 2014 5:4

If you remember me from Mantis, I have since set up the build for the newer version. It turns out that besides fixing a few warnings, there doesn't appear to be any real changes needed to compile against python3.

However, as you have stated, it crashes on start (with either 2 or 3).

luzpaz commented 9 years ago

From @aoloe on August 3, 2014 10:16

I @QuLogic, i was a bit too enthusiastic the other day.

The scripter branch was not a good idea... since the scripter is nothing more than a plugin, I prefer to have a specific repository with only the scripter code in there, that can be pulled into the source code by simply simlinking it in the plugins directory.

I already did create such a repository three weeks ago in my own github account

https://github.com/aoloe/scribus-plugin-scripter

and i will apply your patch to it!

And, as far i can tell, the crash is due to the fact that the scripter is built to to use pyqt4... ... moving to Python 3 is a first necessary step -- at least on Debian testing -- for linking to pyqt5 (which on Debian is only available with Python 3).

luzpaz commented 9 years ago

From @aoloe on August 3, 2014 18:52

Now I got, why I didn't put so much interest in your patch... it's for the old scripter!

Currently, I'm focused in getting the new scripter to work. I hope that your patch will help me getting finding out what has to be changed!

luzpaz commented 9 years ago

From @QuLogic on August 5, 2014 19:39

Yes, I was referring to the new version in my previous comment. There does not seem to be much necessary to get it to compile.

That being said, I don't know if a separate repository just for the scripter makes sense. How are you going to integrate the history back into Scribus' repository?

luzpaz commented 9 years ago

From @aoloe on August 8, 2014 7:52

the scripter is just a plugin, so in my case, it has been proved to be a better choice to work on repositories that contain just the plugin code and symlink the plugin in the code i pull from svn.

those repositories were already on github before the recent move to add scribus itself to github.

since there is no activity yet on the scribus github repository, i prefer to keep my workflow for now.

finally, concerning the commit history: it will in any case be lost, since we will have to put a patch in the bug tracker that will eventually be integrated into the svn version of scribus...