scrimba / community

Repository for public issue-tracking and discussions
https://scrimba.com
911 stars 75 forks source link

Fast-forwarding method inconsistent #260

Open zaydek-old opened 6 years ago

zaydek-old commented 6 years ago

As an author when you fast-forward playback you get the chipmunk effect where the source waveform is compressed and results in a higher-pitch sound which is undesired.

End-users consuming author content get the correct skipped effect, where frames in the audio source are dropped which make for a faster, tonally consistent results

Just want to make clear that authors would benefit from having the skipped version of fast-forwarding and not the chipmunk effect.

somebee commented 6 years ago

I absolutely agree. The challenge is that we use webaudio for the author to enable high precision timing (needed for post-processing). If the recording consists of multiple clips and/or the author has trimmed parts of the audio, we cannot use HTMLAudioElement. The audio element has pretty good native pitch preservation when altering playbackRate, but it is absolutely abysmal when it comes to precision. WebAudio is incredible for high precision, but has no automatic pitch correction. We're looking into solutions, but cannot promise anything :)

zaydek-old commented 6 years ago

I don't know too much about this but I found this: https://peteris.rocks/blog/web-audio-api-playback-rate-preserve-pitch/