search

scrime-u-bordeaux / web-midifile-performer

a web version of the midifile performer software
0 stars 0 forks source link

Why does the IOCTL's "allNotesOff" method send individual 0x80 bytes for every pitch instead of the all notes off message ? #121

Open NyuBlara opened 1 week ago

NyuBlara commented 1 week ago

The expected behavior (sending all notes off/all sound off) is actually found in the IOCTL code, but is commented out. Individual note offs are sent instead.

image

This has actually been the case since the first-ever commit of the IOCTL.

Is there a reason for this ?

josephlarralde commented 1 week ago

I should have commented this more. I think this might be because at the time I found some (maybe old) virtual instruments that didn't support the all notes off message ... we might add a configuration flag enabling all notes off message by default but still allowing the current behavior. Anyway this has to be tested because the actual code might have been written due to some other limitation or specificity of MFP (despite I fail to remember which one).